From 65c29cae291415cbbf0c857d2e108c673a4b2efc Mon Sep 17 00:00:00 2001 From: Robert Honz Date: Sun, 14 Jan 2024 18:04:31 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A0=EF=B8=8F=20`lyrics=5Fsave`=20confi?= =?UTF-8?q?g=20value=20is=20not=20respected.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tidal_dl_ng/download.py | 12 ++++++++---- tidal_dl_ng/model/cfg.py | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/tidal_dl_ng/download.py b/tidal_dl_ng/download.py index 6ee17d6..beaa540 100644 --- a/tidal_dl_ng/download.py +++ b/tidal_dl_ng/download.py @@ -242,11 +242,15 @@ class Download: ) copy_right: str = track.copyright if hasattr(track, "copyright") else "" isrc: str = track.isrc if hasattr(track, "isrc") else "" + lyrics: str = "" - try: - lyrics: str = track.lyrics().subtitles if hasattr(track, "lyrics") else "" - except HTTPError: - lyrics: str = "" + if settings.data.lyrics_save: + # Try to retrieve lyrics. + try: + lyrics: str = track.lyrics().subtitles if hasattr(track, "lyrics") else "" + except HTTPError: + # TODO: Implement proper logging. + print(f"Could not retrieve lyrics for `{name_builder_item(track)}`.") # TODO: Check if it is possible to pass "None" values. m: Metadata = Metadata( diff --git a/tidal_dl_ng/model/cfg.py b/tidal_dl_ng/model/cfg.py index 1083132..d58b3e2 100644 --- a/tidal_dl_ng/model/cfg.py +++ b/tidal_dl_ng/model/cfg.py @@ -10,7 +10,8 @@ from tidal_dl_ng.constants import CoverDimensions, QualityVideo, SkipExisting @dataclass class Settings: skip_existing: SkipExisting = SkipExisting.Disabled - album_cover_save: bool = True + # TODO: Implement cover download to a separate file. + #album_cover_save: bool = True lyrics_save: bool = False # TODO: Implement API KEY selection. api_key_index: bool = 0