From 80419c727e95c7e3e0f21c30f71260cac629a88c Mon Sep 17 00:00:00 2001 From: Robert Honz Date: Fri, 13 Dec 2024 10:14:41 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A0=EF=B8=8F=20Fixed=20`.get=5Fstream(?= =?UTF-8?q?)`=20not=20available=20for=20videos.=20Fixes=20#267?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tidal_dl_ng/download.py | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/tidal_dl_ng/download.py b/tidal_dl_ng/download.py index a5f528b..9098ed1 100644 --- a/tidal_dl_ng/download.py +++ b/tidal_dl_ng/download.py @@ -98,8 +98,8 @@ class Download: def _download( self, media: Track | Video, - stream_manifest: StreamManifest, path_file: pathlib.Path, + stream_manifest: StreamManifest | None = None, ) -> (bool, pathlib.Path): media_name: str = name_builder_item(media) urls: [str] @@ -325,23 +325,25 @@ class Download: self.adjust_quality_video(quality_video) if quality_video else quality_video ) - try: - media_stream: Stream = media.get_stream() - stream_manifest: StreamManifest = media_stream.get_stream_manifest() - except TooManyRequests: - self.fn_logger.exception( - f"Too many requests against TIDAL backend. Skipping '{name_builder_item(media)}'. " - f"Consider to activate delay between downloads." - ) - - return False, "" - except Exception: - self.fn_logger.exception(f"Something went wrong. Skipping '{name_builder_item(media)}'.") - - return False, "" + stream_manifest: StreamManifest | None = None if isinstance(media, Track): - file_extension = media_stream.get_stream_manifest().file_extension + try: + media_stream: Stream = media.get_stream() + stream_manifest = media_stream.get_stream_manifest() + except TooManyRequests: + self.fn_logger.exception( + f"Too many requests against TIDAL backend. Skipping '{name_builder_item(media)}'. " + f"Consider to activate delay between downloads." + ) + + return False, "" + except Exception: + self.fn_logger.exception(f"Something went wrong. Skipping '{name_builder_item(media)}'.") + + return False, "" + + file_extension = stream_manifest.file_extension if self.settings.data.extract_flac and ( stream_manifest.codecs.upper() == Codec.FLAC and file_extension != AudioExtensions.FLAC