6FPS/tidal-dl
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(gui): ✨ Improve filter handling in MainWindow

Browse Source 
* Refactored the filter extraction logic to directly use `header.filter_text(i)` for better clarity.
* Updated the filters list to store tuples of index and text, enhancing the data structure used.
* Ensured that the `proxy_model.filters` is set directly, simplifying the code.
This commit is contained in:
Robert Honz
2025-07-01 15:58:51 +02:00
parent 76f6010a12
commit 99b4347b9a
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tidal_dl_ng/gui.py
+7 -5
View File
@@ -328,11 +328,13 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow):
header = self.tr_results.header() header = self.tr_results.header()
filters: list[str] = [] filters: list[str] = []
for i in range(header.count()): for i in range(header.count()):
# Use getattr to avoid attribute error text: str = header.filter_text(i)
filters.append(getattr(header, "filter_text", lambda x: "")(i))
proxy_model = self.tr_results.model() if text:
if hasattr(proxy_model, "filters"): filters.append((i, text))
proxy_model.filters = filters
proxy_model: HumanProxyModel = self.tr_results.model()
proxy_model.filters = filters
def _init_tree_results(self, tree: QtWidgets.QTreeView, model: QtGui.QStandardItemModel) -> None: def _init_tree_results(self, tree: QtWidgets.QTreeView, model: QtGui.QStandardItemModel) -> None:
"""Initialize the results tree view and its model. """Initialize the results tree view and its model.