Warry
d2c3e8ab8f
Implement comprehensive track information display on hover and resolve all code quality issues to achieve complete ruff compliance. MAJOR FEATURES: - Track details preview on hover with rich metadata display - Async BPM fetching with loading indicator - Enhanced metadata utilities with fuzzy matching - TIDAL API extras integration FILES MODIFIED: 15+ files (core, UI, tests, docs) RUFF COMPLIANCE: 0 errors (89+ violations resolved) - Fixed E999 syntax error in metadata_utils.py - Refactored 10+ complex functions (C901) - Updated error handling (S110, S112, SIM105) - Modernized type hints (UP038) - Fixed naming conflicts (A001, F811) BUG FIXES: - Added missing _on_update_cover() method (11 test failures) - Fixed BPM display and async loading - Improved thread safety TESTING: 30 passed, 1 skipped DOCUMENTATION: Windows PowerShell support, tox troubleshooting
268 lines
10 KiB
Python
268 lines
10 KiB
Python
import pathlib
|
|
|
|
import mutagen
|
|
from mutagen import flac, id3, mp4
|
|
from mutagen.id3 import APIC, SYLT, TALB, TCOM, TCOP, TDRC, TIT2, TOPE, TPE1, TRCK, TSRC, TXXX, USLT, WOAS
|
|
|
|
|
|
class Metadata:
|
|
path_file: str | pathlib.Path
|
|
title: str
|
|
album: str
|
|
albumartist: str
|
|
artists: str
|
|
copy_right: str
|
|
tracknumber: int
|
|
discnumber: int
|
|
totaldisc: int
|
|
totaltrack: int
|
|
date: str
|
|
composer: str
|
|
isrc: str
|
|
lyrics: str
|
|
lyrics_unsynced: str
|
|
path_cover: str
|
|
cover_data: bytes
|
|
album_replay_gain: float
|
|
album_peak_amplitude: float
|
|
track_replay_gain: float
|
|
track_peak_amplitude: float
|
|
url_share: str
|
|
replay_gain_write: bool
|
|
upc: str
|
|
target_upc: dict[str, str]
|
|
explicit: bool
|
|
# New enriched metadata fields
|
|
genre: str
|
|
label: str
|
|
bpm: int | None
|
|
producers: str
|
|
composers_detailed: str
|
|
lyricists: str
|
|
m: mutagen.mp4.MP4 | mutagen.mp4.MP4 | mutagen.flac.FLAC
|
|
|
|
def __init__(
|
|
self,
|
|
path_file: str | pathlib.Path,
|
|
target_upc: dict[str, str],
|
|
album: str = "",
|
|
title: str = "",
|
|
artists: str = "",
|
|
copy_right: str = "",
|
|
tracknumber: int = 0,
|
|
discnumber: int = 0,
|
|
totaltrack: int = 0,
|
|
totaldisc: int = 0,
|
|
composer: str = "",
|
|
isrc: str = "",
|
|
albumartist: str = "",
|
|
date: str = "",
|
|
lyrics: str = "",
|
|
lyrics_unsynced: str = "",
|
|
cover_data: bytes = None,
|
|
album_replay_gain: float = 1.0,
|
|
album_peak_amplitude: float = 1.0,
|
|
track_replay_gain: float = 1.0,
|
|
track_peak_amplitude: float = 1.0,
|
|
url_share: str = "",
|
|
replay_gain_write: bool = True,
|
|
upc: str = "",
|
|
explicit: bool = False,
|
|
# New enriched metadata kwargs (all optional)
|
|
genre: str = "",
|
|
label: str = "",
|
|
bpm: int | None = None,
|
|
producers: str = "",
|
|
composers_detailed: str = "",
|
|
lyricists: str = "",
|
|
):
|
|
self.path_file = path_file
|
|
self.title = title
|
|
self.album = album
|
|
self.albumartist = albumartist
|
|
self.artists = artists
|
|
self.copy_right = copy_right
|
|
self.tracknumber = tracknumber
|
|
self.discnumber = discnumber
|
|
self.totaldisc = totaldisc
|
|
self.totaltrack = totaltrack
|
|
self.date = date
|
|
self.composer = composer
|
|
self.isrc = isrc
|
|
self.lyrics = lyrics
|
|
self.lyrics_unsynced = lyrics_unsynced
|
|
self.cover_data = cover_data
|
|
self.album_replay_gain = album_replay_gain
|
|
self.album_peak_amplitude = album_peak_amplitude
|
|
self.track_replay_gain = track_replay_gain
|
|
self.track_peak_amplitude = track_peak_amplitude
|
|
self.url_share = url_share
|
|
self.replay_gain_write = replay_gain_write
|
|
self.upc = upc
|
|
self.target_upc = target_upc
|
|
self.explicit = explicit
|
|
# Store enriched metadata
|
|
self.genre = genre
|
|
self.label = label
|
|
self.bpm = bpm
|
|
self.producers = producers
|
|
self.composers_detailed = composers_detailed
|
|
self.lyricists = lyricists
|
|
self.m: mutagen.FileType = mutagen.File(self.path_file)
|
|
|
|
def _cover(self) -> bool:
|
|
result: bool = False
|
|
|
|
if self.cover_data:
|
|
if isinstance(self.m, mutagen.flac.FLAC):
|
|
flac_cover = flac.Picture()
|
|
flac_cover.type = id3.PictureType.COVER_FRONT
|
|
flac_cover.data = self.cover_data
|
|
flac_cover.mime = "image/jpeg"
|
|
|
|
self.m.clear_pictures()
|
|
self.m.add_picture(flac_cover)
|
|
elif isinstance(self.m, mutagen.mp3.MP3):
|
|
self.m.tags.add(APIC(encoding=3, data=self.cover_data))
|
|
elif isinstance(self.m, mutagen.mp4.MP4):
|
|
cover_mp4 = mp4.MP4Cover(self.cover_data)
|
|
self.m.tags["covr"] = [cover_mp4]
|
|
|
|
result = True
|
|
|
|
return result
|
|
|
|
def save(self):
|
|
if not self.m.tags:
|
|
self.m.add_tags()
|
|
|
|
if isinstance(self.m, mutagen.flac.FLAC):
|
|
self.set_flac()
|
|
elif isinstance(self.m, mutagen.mp3.MP3):
|
|
self.set_mp3()
|
|
elif isinstance(self.m, mutagen.mp4.MP4):
|
|
self.set_mp4()
|
|
|
|
self._cover()
|
|
self.cleanup_tags()
|
|
self.m.save()
|
|
|
|
return True
|
|
|
|
def set_flac(self):
|
|
self.m.tags["TITLE"] = self.title
|
|
self.m.tags["ALBUM"] = self.album
|
|
self.m.tags["ALBUMARTIST"] = self.albumartist
|
|
self.m.tags["ARTIST"] = self.artists
|
|
self.m.tags["COPYRIGHT"] = self.copy_right
|
|
self.m.tags["TRACKNUMBER"] = str(self.tracknumber)
|
|
self.m.tags["TRACKTOTAL"] = str(self.totaltrack)
|
|
self.m.tags["DISCNUMBER"] = str(self.discnumber)
|
|
self.m.tags["DISCTOTAL"] = str(self.totaldisc)
|
|
self.m.tags["DATE"] = self.date
|
|
self.m.tags["COMPOSER"] = self.composer if self.composer else self.composers_detailed
|
|
self.m.tags["ISRC"] = self.isrc
|
|
self.m.tags["LYRICS"] = self.lyrics
|
|
self.m.tags["UNSYNCEDLYRICS"] = self.lyrics_unsynced
|
|
self.m.tags["URL"] = self.url_share
|
|
self.m.tags[self.target_upc["FLAC"]] = self.upc
|
|
# Enriched fields
|
|
if self.genre:
|
|
self.m.tags["GENRE"] = self.genre
|
|
if self.label:
|
|
# Using LABEL; some tools map PUBLISHER, but LABEL is widely recognised in Vorbis.
|
|
self.m.tags["LABEL"] = self.label
|
|
if self.bpm is not None:
|
|
self.m.tags["BPM"] = str(self.bpm)
|
|
if self.producers:
|
|
self.m.tags["PRODUCER"] = self.producers
|
|
if self.lyricists:
|
|
self.m.tags["LYRICIST"] = self.lyricists
|
|
|
|
if self.replay_gain_write:
|
|
self.m.tags["REPLAYGAIN_ALBUM_GAIN"] = str(self.album_replay_gain)
|
|
self.m.tags["REPLAYGAIN_ALBUM_PEAK"] = str(self.album_peak_amplitude)
|
|
self.m.tags["REPLAYGAIN_TRACK_GAIN"] = str(self.track_replay_gain)
|
|
self.m.tags["REPLAYGAIN_TRACK_PEAK"] = str(self.track_peak_amplitude)
|
|
|
|
def set_mp3(self):
|
|
# ID3 Frame (tags) overview: https://exiftool.org/TagNames/ID3.html / https://id3.org/id3v2.3.0
|
|
# Mapping overview: https://docs.mp3tag.de/mapping/
|
|
self.m.tags.add(TIT2(encoding=3, text=self.title))
|
|
self.m.tags.add(TALB(encoding=3, text=self.album))
|
|
self.m.tags.add(TOPE(encoding=3, text=self.albumartist))
|
|
self.m.tags.add(TPE1(encoding=3, text=self.artists))
|
|
self.m.tags.add(TCOP(encoding=3, text=self.copy_right))
|
|
self.m.tags.add(TRCK(encoding=3, text=str(self.tracknumber)))
|
|
self.m.tags.add(TRCK(encoding=3, text=self.discnumber))
|
|
self.m.tags.add(TDRC(encoding=3, text=self.date))
|
|
self.m.tags.add(TCOM(encoding=3, text=self.composer if self.composer else self.composers_detailed))
|
|
self.m.tags.add(TSRC(encoding=3, text=self.isrc))
|
|
self.m.tags.add(SYLT(encoding=3, desc="text", text=self.lyrics))
|
|
self.m.tags.add(USLT(encoding=3, desc="text", text=self.lyrics_unsynced))
|
|
self.m.tags.add(WOAS(encoding=3, text=self.isrc))
|
|
self.m.tags.add(TXXX(encoding=3, desc=self.target_upc["MP3"], text=self.upc))
|
|
# Enriched fields
|
|
if self.genre:
|
|
from mutagen.id3 import TCON
|
|
|
|
self.m.tags.add(TCON(encoding=3, text=self.genre))
|
|
if self.label:
|
|
from mutagen.id3 import TPUB
|
|
|
|
self.m.tags.add(TPUB(encoding=3, text=self.label))
|
|
if self.bpm is not None:
|
|
from mutagen.id3 import TBPM
|
|
|
|
self.m.tags.add(TBPM(encoding=3, text=str(self.bpm)))
|
|
if self.producers:
|
|
self.m.tags.add(TXXX(encoding=3, desc="PRODUCER", text=self.producers))
|
|
if self.lyricists:
|
|
self.m.tags.add(TXXX(encoding=3, desc="LYRICIST", text=self.lyricists))
|
|
|
|
if self.replay_gain_write:
|
|
self.m.tags.add(TXXX(encoding=3, desc="REPLAYGAIN_ALBUM_GAIN", text=str(self.album_replay_gain)))
|
|
self.m.tags.add(TXXX(encoding=3, desc="REPLAYGAIN_ALBUM_PEAK", text=str(self.album_peak_amplitude)))
|
|
self.m.tags.add(TXXX(encoding=3, desc="REPLAYGAIN_TRACK_GAIN", text=str(self.track_replay_gain)))
|
|
self.m.tags.add(TXXX(encoding=3, desc="REPLAYGAIN_TRACK_PEAK", text=str(self.track_peak_amplitude)))
|
|
|
|
def set_mp4(self):
|
|
self.m.tags["\xa9nam"] = self.title
|
|
self.m.tags["\xa9alb"] = self.album
|
|
self.m.tags["aART"] = self.albumartist
|
|
self.m.tags["\xa9ART"] = self.artists
|
|
self.m.tags["cprt"] = self.copy_right
|
|
self.m.tags["trkn"] = [[self.tracknumber, self.totaltrack]]
|
|
self.m.tags["disk"] = [[self.discnumber, self.totaldisc]]
|
|
if self.genre:
|
|
self.m.tags["\xa9gen"] = self.genre
|
|
self.m.tags["\xa9day"] = self.date
|
|
self.m.tags["\xa9wrt"] = self.composer if self.composer else self.composers_detailed
|
|
self.m.tags["\xa9lyr"] = self.lyrics
|
|
self.m.tags["----:com.apple.iTunes:UNSYNCEDLYRICS"] = self.lyrics_unsynced.encode("utf-8")
|
|
self.m.tags["isrc"] = self.isrc
|
|
self.m.tags["\xa9url"] = self.url_share
|
|
self.m.tags[f"----:com.apple.iTunes:{self.target_upc['MP4']}"] = self.upc.encode("utf-8")
|
|
self.m.tags["rtng"] = [1 if self.explicit else 0]
|
|
# Custom iTunes free-form tags for label / credits
|
|
if self.label:
|
|
self.m.tags["----:com.apple.iTunes:LABEL"] = self.label.encode("utf-8")
|
|
if self.producers:
|
|
self.m.tags["----:com.apple.iTunes:PRODUCER"] = self.producers.encode("utf-8")
|
|
if self.lyricists:
|
|
self.m.tags["----:com.apple.iTunes:LYRICIST"] = self.lyricists.encode("utf-8")
|
|
if self.bpm is not None:
|
|
# Standard MP4 tempo atom
|
|
self.m.tags["tmpo"] = [int(self.bpm)]
|
|
|
|
if self.replay_gain_write:
|
|
self.m.tags["----:com.apple.iTunes:REPLAYGAIN_ALBUM_GAIN"] = str(self.album_replay_gain).encode("utf-8")
|
|
self.m.tags["----:com.apple.iTunes:REPLAYGAIN_ALBUM_PEAK"] = str(self.album_peak_amplitude).encode("utf-8")
|
|
self.m.tags["----:com.apple.iTunes:REPLAYGAIN_TRACK_GAIN"] = str(self.track_replay_gain).encode("utf-8")
|
|
self.m.tags["----:com.apple.iTunes:REPLAYGAIN_TRACK_PEAK"] = str(self.track_peak_amplitude).encode("utf-8")
|
|
|
|
def cleanup_tags(self):
|
|
for key, value in self.m.tags.items():
|
|
if value == "" or value == [""]:
|
|
del self.m.tags[key]
|